-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add abouthiroppy to collaborators #11080
Closed
hiroppy
wants to merge
1
commit into
nodejs:master
from
hiroppy:feature/add-abouthiroppy-to-collaborator
Closed
doc: add abouthiroppy to collaborators #11080
hiroppy
wants to merge
1
commit into
nodejs:master
from
hiroppy:feature/add-abouthiroppy-to-collaborator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
force-pushed
the
feature/add-abouthiroppy-to-collaborator
branch
from
January 31, 2017 13:39
bb43422
to
8c6947f
Compare
addaleax
approved these changes
Jan 31, 2017
santigimeno
approved these changes
Jan 31, 2017
evanlucas
approved these changes
Jan 31, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Welcome aboard!
hiroppy
added a commit
that referenced
this pull request
Jan 31, 2017
PR-URL: #11080 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Landed in 04da44a. |
gibfahn
reviewed
Jan 31, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belated LGTM
evanlucas
pushed a commit
that referenced
this pull request
Jan 31, 2017
PR-URL: #11080 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add @abouthiroppy as collaborators to README.md.
Checklist
Affected core subsystem(s)
doc