Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: simplify URLSearchParams import #11111

Closed
wants to merge 1 commit into from
Closed

benchmark: simplify URLSearchParams import #11111

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Feb 2, 2017
@italoacasas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/6191/console

@TimothyGu
Copy link
Member Author

Landed in 590626b.

@TimothyGu TimothyGu closed this Feb 3, 2017
@TimothyGu TimothyGu deleted the urlsearchparams-bench branch February 3, 2017 20:24
TimothyGu added a commit that referenced this pull request Feb 3, 2017
@TimothyGu
benchmark: simplify URLSearchParams import
590626b 
PR-URL: #11111
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 4, 2017
@TimothyGu @italoacasas
benchmark: simplify URLSearchParams import
cf55e12 
PR-URL: nodejs#11111
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@italoacasas italoacasas mentioned this pull request Feb 5, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@TimothyGu @italoacasas
benchmark: simplify URLSearchParams import
94555c9 
PR-URL: nodejs#11111
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@TimothyGu @krydos
benchmark: simplify URLSearchParams import
f5f6b79 
PR-URL: nodejs#11111
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@hiroppy hiroppy hiroppy approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@italoacasas italoacasas italoacasas approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TimothyGu @italoacasas @jasnell @targos @hiroppy @joyeecheung @nodejs-github-bot