Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: simplify WPT.assert_throws() #11126

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 2, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test url

@Trott Trott added test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 2, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2017
@Trott Trott requested a review from joyeecheung February 2, 2017 22:05
@Trott
Copy link
Member Author

Trott commented Feb 2, 2017

/cc @joyeecheung in case there is a subtlety I am missing

@Trott
Copy link
Member Author

Trott commented Feb 2, 2017

Hmmm...oh, I think I see, this API is dictated elsewhere so we (probably) don't want to change it even if it might otherwise make sense to change it for our narrow use in our own tests?

@Trott
Copy link
Member Author

Trott commented Feb 2, 2017

(Aside: It would be great if common.WPT could be documented in the test/README.md where the common module API is documented.)

@TimothyGu
Copy link
Member

this API is dictated elsewhere so we (probably) don't want to change it even if it might otherwise make sense to change it for our narrow use in our own tests?

Yeah, making this kind of subtle changes makes importing tests more difficult. Check out @joyeecheung's explanation (#11079 (comment)) for how WPTs are imported.

@Trott
Copy link
Member Author

Trott commented Feb 2, 2017

(Minimal doc stub for common.WPT here: #11127 If someone wants to do something more complete and informative, by all means, close that PR and open a better one.)

@Trott
Copy link
Member Author

Trott commented Feb 2, 2017

OK, makes sense to me. I'll close this.

@Trott Trott closed this Feb 2, 2017
@Trott Trott deleted the chewbacca branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants