Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve punycode test coverage #11144

Closed
wants to merge 1 commit into from

Conversation

seppevs
Copy link
Contributor

@seppevs seppevs commented Feb 3, 2017

Adds two additional tests for mapDomain function in punycode.js.

When an email address is given to the toASCII() and toUnicode() functions, only the parts before the '@' character should be encoded/decoded.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

N/A

Adds two additional tests for mapDomain function in punycode.js.
When an email address is given to the toASCII() and toUnicode() functions, only the parts before the '@' character should be encoded/decoded.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 3, 2017
@hiroppy hiroppy added the punycode Issues and PRs related to the punycode module bundled in Node.js. label Feb 3, 2017
@hiroppy
Copy link
Member

hiroppy commented Feb 5, 2017

Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI is happy.

@seppevs
Copy link
Contributor Author

seppevs commented Feb 6, 2017

The CI fails, but I don't think it's caused by my changes?

@joyeecheung
Copy link
Member

Refs: #10990 (comment)

@addaleax @mathiasbynens If we move punycode.js to deps, should we upstream the tests?

@joyeecheung
Copy link
Member

BTW: CI failure looks unrelated.

@mathiasbynens
Copy link
Contributor

mathiasbynens commented Feb 6, 2017

@joyeecheung There’s an upstream test for this already: https://github.com/bestiejs/punycode.js/blob/9aeca525bba478206c6e1b5501e063f3db7bda7f/tests/tests.js#L211-L215 If I’m missing something and this patch somehow tests a different code path, please submit a PR to https://github.com/bestiejs/punycode.js as well.

@seppevs
Copy link
Contributor Author

seppevs commented Feb 7, 2017

@mathiasbynens : the upstream test seems to cover the same code.

@jasnell
Copy link
Member

jasnell commented Feb 7, 2017

@jasnell
Copy link
Member

jasnell commented Feb 11, 2017

jasnell pushed a commit that referenced this pull request Feb 13, 2017
Adds two additional tests for mapDomain function in punycode.js.
When an email address is given to the toASCII() and toUnicode()
functions, only the parts before the '@' character should be
encoded/decoded.

PR-URL: #11144
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 13, 2017

Landed in c6238e2

@jasnell jasnell closed this Feb 13, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
Adds two additional tests for mapDomain function in punycode.js.
When an email address is given to the toASCII() and toUnicode()
functions, only the parts before the '@' character should be
encoded/decoded.

PR-URL: nodejs#11144
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
Adds two additional tests for mapDomain function in punycode.js.
When an email address is given to the toASCII() and toUnicode()
functions, only the parts before the '@' character should be
encoded/decoded.

PR-URL: #11144
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
Adds two additional tests for mapDomain function in punycode.js.
When an email address is given to the toASCII() and toUnicode()
functions, only the parts before the '@' character should be
encoded/decoded.

PR-URL: #11144
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
Adds two additional tests for mapDomain function in punycode.js.
When an email address is given to the toASCII() and toUnicode()
functions, only the parts before the '@' character should be
encoded/decoded.

PR-URL: #11144
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
Adds two additional tests for mapDomain function in punycode.js.
When an email address is given to the toASCII() and toUnicode()
functions, only the parts before the '@' character should be
encoded/decoded.

PR-URL: #11144
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
punycode Issues and PRs related to the punycode module bundled in Node.js. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants