backport: Deprecate old debug protocol in docs #11172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
debugger
doc
2 tasks
jkrems
changed the title
jkrems
changed the title
italoacasas
force-pushed
the
v7.x-staging
branch
from
ac72c3e
to
2f1ce29
Compare
|
@jkrems can you rebase this please. |
jkrems
force-pushed
the
jk-backport-pr10320
branch
2 times, most recently
from
f2f0f00
to
6bed46e
Compare
|
Re-applied the commit to the new |
italoacasas
force-pushed
the
v7.x-staging
branch
from
1fde990
to
9c45758
Compare
Due to changes in V8, the debug protocol will no longer work in Node.js 8.0.0. Note this in the documentation. PR-URL: nodejs#10320 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jkrems
force-pushed
the
jk-backport-pr10320
branch
from
6bed46e
to
cd54e3e
Compare
|
Re-applied the commit to the new |
|
Landed in staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #10320, the only conflict was the V8 protocol URL that changed in the meantime.
Due to changes in V8, the debug protocol will no longer work in Node.js
8.0.0. Note this in the documentation.
PR-URL: #10320
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com
Checklist
Affected core subsystem(s)
doc