Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: synchronize + update _toc.md and all.md #11206

Closed
wants to merge 1 commit into from
Closed

doc: synchronize + update _toc.md and all.md #11206

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Feb 6, 2017

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

  • Add new docs to the both files
  • Synchronize the order of docs in all.md with _toc.md

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Feb 7, 2017
@vsemozhetbyt
Copy link
Contributor Author

@jasnell @Fishrock123 Could this be landed?

@Fishrock123
Copy link
Contributor

Yep! Apologies for the delay, landed in e4e7cd5! 🎉

Fishrock123 pushed a commit that referenced this pull request Feb 15, 2017
PR-URL: #11206
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the _toc.md-all.md branch February 15, 2017 04:20
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 16, 2017
PR-URL: nodejs#11206
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
PR-URL: #11206
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Feb 25, 2017
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

Need to determine if this should be backported to v6 or v4.

@MylesBorins
Copy link
Contributor

backport if neccessary, set do not land for 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants