test: remove dependency on node-weak #11239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
|
jasnell
approved these changes
Feb 8, 2017
|
@richardlau Right you are, updated. |
richardlau
reviewed
Feb 8, 2017
There was a problem hiding this comment.
node-weak is also referenced in the LICENSE file via tools/license-builder.sh.
test/gc/binding.js
Outdated
| try { | ||
| module.exports = require('./build/Release/binding').ongc; | ||
| } catch (e) { | ||
| module.exports = require('./build/Debug/binding').ongc; |
There was a problem hiding this comment.
Is it correct to prefer a binding in Release (e.g. if tests are run with node_g)?
For example, build and test Release and then build and test Debug without cleaning in-between.
I don't think it's possible for the makefile to build the binding in debug mode (it always runs node-gyp with the Release node) -- vcbuild.bat runs node-gyp with "%config%\node".
There was a problem hiding this comment.
You're right that the build won't compile a debug version but it seems convenient for manual testing/debugging. What would you do instead?
There was a problem hiding this comment.
Try to load the version that matched the mode (release/debug) of the node process first and fallback to the other?
There was a problem hiding this comment.
Not a bad idea but I decided to use the same logic we use in test/addons for the sake of consistency. PTAL.
bnoordhuis
force-pushed
the
cleanup-gc-tests
branch
from
e2f2ba9 to
92aaa38
Compare
Funny, I didn't even realize I own the copyright. At any rate, removed! |
richardlau
approved these changes
Feb 9, 2017
2 tasks
bnoordhuis
force-pushed
the
cleanup-gc-tests
branch
from
45c894a to
cc9955a
Compare
Rewrite the tests in test/gc so that they no longer call process.exit(). Instead they exit gracefully now. PR-URL: nodejs#11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Replace node-weak with a small hand-rolled add-on. We can now drop node-weak and nan, reducing the size of the source tree by about 750 kB and the size of the tarball by about 150-300 kB. PR-URL: nodejs#11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Since the previous commit obsoleted them, remove them. PR-URL: nodejs#11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
bnoordhuis
force-pushed
the
cleanup-gc-tests
branch
from
cc9955a to
75019df
Compare
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
Rewrite the tests in test/gc so that they no longer call process.exit(). Instead they exit gracefully now. PR-URL: #11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
Replace node-weak with a small hand-rolled add-on. We can now drop node-weak and nan, reducing the size of the source tree by about 750 kB and the size of the tarball by about 150-300 kB. PR-URL: #11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
Since the previous commit obsoleted them, remove them. PR-URL: #11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Rewrite the tests in test/gc so that they no longer call process.exit(). Instead they exit gracefully now. PR-URL: nodejs#11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Replace node-weak with a small hand-rolled add-on. We can now drop node-weak and nan, reducing the size of the source tree by about 750 kB and the size of the tarball by about 150-300 kB. PR-URL: nodejs#11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Since the previous commit obsoleted them, remove them. PR-URL: nodejs#11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Rewrite the tests in test/gc so that they no longer call process.exit(). Instead they exit gracefully now. PR-URL: nodejs#11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Replace node-weak with a small hand-rolled add-on. We can now drop node-weak and nan, reducing the size of the source tree by about 750 kB and the size of the tarball by about 150-300 kB. PR-URL: nodejs#11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Since the previous commit obsoleted them, remove them. PR-URL: nodejs#11239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
needs backport PRs to land in v4 or v6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace node-weak with a small hand-rolled add-on. We can now drop node-weak and nan, reducing the size of the source tree by about 750 kB (and the size of the tarball by about 150-300 kB.)
The first commit cleans up the tests, the second introduces the add-on, the third one drops nan and node-weak.