Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adapt test-debugger-pid to localized Windows #11270

Closed
wants to merge 1 commit into from
Closed

test: adapt test-debugger-pid to localized Windows #11270

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, debugger

Fixes: #11250

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 9, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request Feb 9, 2017
Closed
Trott
Trott approved these changes Feb 9, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott
Copy link
Member

Trott commented Feb 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6325/

@Trott Trott added the debugger label Feb 9, 2017
jasnell pushed a commit that referenced this pull request Feb 11, 2017
@vsemozhetbyt @jasnell
test: adapt test-debugger-pid to localized Windows
a29c85a 
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 11, 2017

Landed in a29c85a

@jasnell jasnell closed this Feb 11, 2017
@vsemozhetbyt vsemozhetbyt deleted the test-debugger-pid branch February 11, 2017 17:02
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
@vsemozhetbyt @italoacasas
test: adapt test-debugger-pid to localized Windows
f47bc4a 
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@vsemozhetbyt @italoacasas
test: adapt test-debugger-pid to localized Windows
2f15efb 
PR-URL: nodejs#11270
Fixes: nodejs#11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@vsemozhetbyt @krydos
test: adapt test-debugger-pid to localized Windows
98091de 
PR-URL: nodejs#11270
Fixes: nodejs#11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

requires a backport PR in order to land on v4

jasnell pushed a commit that referenced this pull request Mar 7, 2017
@vsemozhetbyt @jasnell
test: adapt test-debugger-pid to localized Windows
39c8a36 
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@vsemozhetbyt @MylesBorins
test: adapt test-debugger-pid to localized Windows
6694c26 
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @Trott @jasnell @nodejs-github-bot