Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase setMulticastLoopback() coverage #11277

Merged
merged 1 commit into from
Feb 13, 2017
Merged

test: increase setMulticastLoopback() coverage #11277

merged 1 commit into from
Feb 13, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 10, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 10, 2017
@cjihrig cjihrig added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 10, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6339/

@cjihrig
test: increase setMulticastLoopback() coverage
93982c0 
PR-URL: nodejs#11277
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 93982c0 into nodejs:master Feb 13, 2017
@cjihrig cjihrig deleted the loopback branch February 13, 2017 15:17
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@cjihrig @italoacasas
test: increase setMulticastLoopback() coverage
1f3eee4 
PR-URL: nodejs#11277
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 14, 2017
Merged
mhdawson
mhdawson reviewed Feb 14, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @jasnell
test: increase setMulticastLoopback() coverage
eec96ef 
PR-URL: #11277
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @jasnell
test: increase setMulticastLoopback() coverage
67f9f85 
PR-URL: #11277
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
test: increase setMulticastLoopback() coverage
336f1bd 
PR-URL: #11277
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
test: increase setMulticastLoopback() coverage
f854d8c 
PR-URL: #11277
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson left review comments

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @jasnell @mhdawson @nodejs-github-bot