test: cases to querystring related to empty string #11329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroppy
added
the
querystring
hiroppy
suggested changes
Feb 12, 2017
test/parallel/test-querystring.js
Outdated
| check(qs.parse(), {}); | ||
|
|
||
| // empty sep | ||
| check(qs.parse('a', []), { a: '' }) |
There was a problem hiding this comment.
Please add a semicolon to this line;)
test/parallel/test-querystring.js
Outdated
| check(qs.parse('a', []), { a: '' }) | ||
|
|
||
| // empty eq | ||
| check(qs.parse('a', null, []), { '': 'a' }) |
There was a problem hiding this comment.
Oops, sorry for both of them... I've updated immediately.
watilde
force-pushed
the
test-qs-empty
branch
from
6540045
to
e06dcc4
Compare
hiroppy
approved these changes
Feb 12, 2017
kashav
approved these changes
Feb 13, 2017
jasnell
approved these changes
Feb 13, 2017
lpinca
reviewed
Feb 13, 2017
test/parallel/test-querystring.js
Outdated
| @@ -232,8 +232,20 @@ assert.doesNotThrow(function() { | |||
| assert.strictEqual(f, 'a:b;q:x%3Ay%3By%3Az'); | |||
| } | |||
|
|
|||
| // empty string | |||
| assert.strictEqual('', qs.stringify()); | |||
There was a problem hiding this comment.
Nit: can you please swap the parameters? actual first, then expected.
+ Add cases to `qs.stringify` that return empty string + Add cases to `qs.parse` when `sep` or `eq` is empty
watilde
force-pushed
the
test-qs-empty
branch
from
e06dcc4
to
5e8627c
Compare
lpinca
approved these changes
Feb 13, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 16, 2017
+ Add cases to `qs.stringify` that return empty string + Add cases to `qs.parse` when `sep` or `eq` is empty PR-URL: #11329 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in eec216f |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
+ Add cases to `qs.stringify` that return empty string + Add cases to `qs.parse` when `sep` or `eq` is empty PR-URL: nodejs#11329 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
+ Add cases to `qs.stringify` that return empty string + Add cases to `qs.parse` when `sep` or `eq` is empty PR-URL: #11329 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
+ Add cases to `qs.stringify` that return empty string + Add cases to `qs.parse` when `sep` or `eq` is empty PR-URL: #11329 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
+ Add cases to `qs.stringify` that return empty string + Add cases to `qs.parse` when `sep` or `eq` is empty PR-URL: #11329 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase coverage of querystring:
This test case will cover these lines:
node/lib/querystring.js
Line 250 in 4cafa60
node/lib/querystring.js
Line 254 in 4cafa60
Together with #11326, the coverage will be 100%.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)