Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix building with ninja on linux #11348

Closed
wants to merge 1 commit into from
Closed

build: fix building with ninja on linux #11348

wants to merge 1 commit into from

Commits on Feb 13, 2017

  1. build: fix building with ninja on linux 

    On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed
to `ninja` on OS X which places it outside of that directory. Furthermore, the
expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`.
This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the
correct values for `ninja` on Linux specifically.

Fixes: nodejs#9861
    @kenany
    kenany committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    043a16f View commit details
    Browse the repository at this point in the history