errors socket_list : Migrate errors to internal/errors.js #11356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
errors
jasnell
requested changes
Feb 13, 2017
lib/internal/socket_list.js
Outdated
| @@ -22,7 +24,7 @@ SocketListSend.prototype._request = function(msg, cmd, callback) { | |||
|
|
|||
| function onclose() { | |||
| self.slave.removeListener('internalMessage', onreply); | |||
| callback(new Error('Slave closed before reply')); | |||
| callback(new errors.Error('SLAVE_CLOSED_BEFORE_REPLY')); | |||
There was a problem hiding this comment.
Please use the naming pattern ERR_***
|
@jasnell requested changes are done. |
80 tasks
jasnell
reviewed
Feb 14, 2017
lib/internal/errors.js
Outdated
| @@ -86,3 +86,4 @@ module.exports = exports = { | |||
| // Note: Please try to keep these in alphabetical order | |||
| E('ERR_ASSERTION', (msg) => msg); | |||
| // Add new errors from here... | |||
| E('ERR_SLAVE_CLOSED_BEFORE_REPLY','Slave closed before reply'); | |||
There was a problem hiding this comment.
nit: running make lint should complain on this. There needs to be a single space after the comma before 'Slave...
joyeecheung
reviewed
Feb 14, 2017
lib/internal/socket_list.js
Outdated
| @@ -22,7 +24,7 @@ SocketListSend.prototype._request = function(msg, cmd, callback) { | |||
|
|
|||
| function onclose() { | |||
| self.slave.removeListener('internalMessage', onreply); | |||
| callback(new Error('Slave closed before reply')); | |||
| callback(new errors.Error('ERR_SLAVE_CLOSED_BEFORE_REPLY')); | |||
There was a problem hiding this comment.
Are there other PR documenting this error code? Otherwise this needs a documentation.
There was a problem hiding this comment.
Refs: Documenting new errors
jasnell
added
the
semver-major
|
@bougarfaoui Do you want to take a stab at addressing the comments? Thanks! |
|
I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed. |
|
I'm following up |
refack
force-pushed
the
internal-errors-socket_list
branch
2 times, most recently
from
7cc85e2 to
892ff1c
Compare
refack
force-pushed
the
internal-errors-socket_list
branch
from
892ff1c to
e4f04f5
Compare
refack
force-pushed
the
internal-errors-socket_list
branch
from
e4f04f5 to
71cb153
Compare
refack
removed
blocked
|
@joyeecheung @fhinkel PTAL ( @Trott ? ) |
Trott
reviewed
Jul 20, 2017
doc/api/errors.md
Outdated
| <a id="ERR_CHILD_CLOSED_BEFORE_REPLY"></a> | ||
| ### ERR_CHILD_CLOSED_BEFORE_REPLY | ||
|
|
||
| Used when a child process is closed before the parent got a replay. |
There was a problem hiding this comment.
Typo: replay -> reply
Micronit: got -> received
Trott
approved these changes
Jul 20, 2017
refack
pushed a commit
to refack/node
that referenced
this pull request
Jul 21, 2017
PR-URL: nodejs#11356 Refs: nodejs#11273 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in a03d8ce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #11273
Semver-major because this updates specific error messages and converts errors over to use the new internal/errors.js mechanism.
cc @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors, socket_list