Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused variable #11361

Closed
wants to merge 1 commit into from
Closed

src: remove unused variable #11361

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 13, 2017

I noticed a warning while compiling. Removing an unused variable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Feb 13, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 13, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/6394/

EDIT: New CI: https://ci.nodejs.org/job/node-test-pull-request/6403/

@mscdex
Copy link
Contributor

mscdex commented Feb 14, 2017

LGTM

@ChALkeR
Copy link
Member

ChALkeR commented Feb 15, 2017

It's unused since e34ee1d (#10882).

Btw, this commit message probably needs a description (like mentioning the above commit/PR).

@jasnell
Copy link
Member

jasnell commented Feb 15, 2017

I'm landing this, will add the description

jasnell pushed a commit that referenced this pull request Feb 15, 2017
@cjihrig @jasnell
src: remove unused variable in node_crypto
0593528 
env was unused since the ref'd commit

Ref: e34ee1d
PR-URL: #11361
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell
Copy link
Member

jasnell commented Feb 15, 2017

Landed in 0593528

@jasnell jasnell closed this Feb 15, 2017
@cjihrig cjihrig deleted the unused branch February 15, 2017 21:40
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 16, 2017
@cjihrig @italoacasas
src: remove unused variable in node_crypto
06693ab 
env was unused since the ref'd commit

Ref: nodejs@e34ee1d
PR-URL: nodejs#11361
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
@cjihrig @italoacasas
src: remove unused variable in node_crypto
7d47f27 
env was unused since the ref'd commit

Ref: e34ee1d
PR-URL: #11361
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @mscdex @ChALkeR @jasnell @bnoordhuis @addaleax @nodejs-github-bot