Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: fix handling of ? in URLSearchParams creation #11372

Closed
wants to merge 2 commits into from
Closed

url: fix handling of ? in URLSearchParams creation #11372

wants to merge 2 commits into from

Conversation

TimothyGu
Copy link
Member

@TimothyGu TimothyGu commented Feb 14, 2017 •
edited
Loading

Fixes: #11093
Ref: whatwg/url#248

CI: https://ci.nodejs.org/job/node-test-pull-request/6401/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 14, 2017
@TimothyGu
Copy link
Member Author

Landed in fa41dd1.

@TimothyGu TimothyGu closed this Feb 17, 2017
@TimothyGu TimothyGu deleted the gh-11093 branch February 17, 2017 05:12
TimothyGu added a commit that referenced this pull request Feb 17, 2017
@TimothyGu
url: fix handling of ? in URLSearchParams creation
fa41dd1 
PR-URL: #11372
Fixes: #11093
Ref: whatwg/url#248
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
@TimothyGu @italoacasas
url: fix handling of ? in URLSearchParams creation
5f10827 
PR-URL: nodejs#11372
Fixes: nodejs#11093
Ref: whatwg/url#248
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimothyGu @jasnell @joyeecheung @nodejs-github-bot