test: cover dgram socket close during bind case #11383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Feb 15, 2017
This commit tests the scenario where a dgram socket closes during a call to Socket#bind(). PR-URL: nodejs#11383 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
cjihrig
force-pushed
the
close-during-bind
branch
from
2e1b7dc to
a196895
Compare
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
This commit tests the scenario where a dgram socket closes during a call to Socket#bind(). PR-URL: nodejs#11383 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
This commit tests the scenario where a dgram socket closes during a call to Socket#bind(). PR-URL: #11383 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
|
Requires the common.mustNotCall() function to be backported to v6 and v4 before this can be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tests the scenario where a dgram socket closes during a call to
Socket#bind().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test