cluster: properly handle --inspect-{brk,port} #11386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Feb 14, 2017
mscdex
added
cluster
bnoordhuis
approved these changes
Feb 15, 2017
| @@ -27,6 +27,8 @@ if (cluster.isMaster) { | |||
| fork(4, ['--inspect', '--debug']); | |||
| fork(5, [`--debug=${debuggerPort}`, '--inspect']); | |||
| fork(6, ['--inspect', `--debug-port=${debuggerPort}`]); | |||
| fork(7, [`--inspect-port=${debuggerPort}`]); | |||
| fork(8, ['--inspect', `--inspect-port=${debuggerPort}`]); | |||
There was a problem hiding this comment.
The omission of --inspect-brk is intentional?
There was a problem hiding this comment.
IIRC, the brk flags interfere with the child process aspect of the test.
There was a problem hiding this comment.
@bnoordhuis @Fishrock123 is this disposition acceptable to you, or do you think that #11420 needs to be addressed before this lands?
targos
approved these changes
Feb 15, 2017
jasnell
approved these changes
Feb 19, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 19, 2017
PR-URL: #11386 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landedin 389b9e4 |
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
PR-URL: #11386 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster wasn't properly handling the
--inspect-brk=${port}and--inspect-port=${port}arguments to the children.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
cluster, test