Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test cases for path #11453

Closed
wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Feb 18, 2017

Add test cases for the following line.
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1364
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1347

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 18, 2017
@hiroppy hiroppy added the path Issues and PRs related to the path subsystem. label Feb 18, 2017
@hiroppy
Copy link
Member Author

hiroppy commented Feb 18, 2017

jasnell pushed a commit that referenced this pull request Feb 19, 2017
Add test cases for the following line.
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1364
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1347

PR-URL: #11453
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 19, 2017

Landed in e18ebe8

@jasnell jasnell closed this Feb 19, 2017
@hiroppy hiroppy deleted the feature/add-tests-to-path branch February 19, 2017 23:49
addaleax pushed a commit that referenced this pull request Feb 22, 2017
Add test cases for the following line.
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1364
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1347

PR-URL: #11453
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
jasnell pushed a commit that referenced this pull request Mar 7, 2017
Add test cases for the following line.
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1364
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1347

PR-URL: #11453
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

this would need a backport PR to land on v4

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
Add test cases for the following line.
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1364
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1347

PR-URL: #11453
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
path Issues and PRs related to the path subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants