Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: add Franziska Hinkelmann to the CTC #11488

Closed
wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 22, 2017

@fhinkel was nominated privately within the @nodejs/ctc to join as a new member. Both the CTC and Franziska have responded positively so we have moved into the trial phase where she joins the CTC calls as an observer for a few weeks prior to a formal vote. This trial serves the purpose of ensuring that the nominee is happy to proceed and that the CTC is also comfortable with the addition, in practice though it serves mainly as an ease-in process for the nominee and so the CTC doesn't just spring sudden news on @nodejs/collaborators.

Franziska is with the V8 team at Google, working on the V8 API and ES6 performance improvements. She brings some very impressive credentials as a Node.js Collaborator and will make a very valuable CTC addition:

  • Owns the VM module in V8, which is heavily used in Jest and Jsdom & made the necessary API changes in V8 to fix its long standing issues
  • Currently mentoring an Outreachy Node.js student
  • A TC39 attendee, involved in the discussion around ES6 vs CommonJS modules
  • Responsible for the V8-Node integration branch and backports / updates V8 in Node.js.
  • Involved in review of the NAPI proposal and made sure that it works with V8

Voting will likely take place here on GitHub since it's becoming increasingly difficult to gather the globally distributed CTC for real-time meetings, we'll announce that when it happens in a couple of weeks.

As always, we look forward to the benefits that new membership brings to the CTC. It's a fantastic opportunity to broaden our perspective and challenge existing thinking about how things should be done!

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 22, 2017
@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Feb 22, 2017
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(+1 implied by LGTM.)

Copy link

@misterdjules misterdjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voting +1 with this review approval.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 🎉

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 25, 2017

We're well over the required 2/3 affirmative vote! :-)

@Trott
Copy link
Member

Trott commented Feb 26, 2017

We're well over the required 2/3 affirmative vote! :-)

If the 2/3 comment was a joke, please disregard my failure to be 100% certain of that. :-D

For the record: The CTC may add additional members to the CTC by a standard CTC motion. So no 2/3 requirement.

So yeah, we're waaaaaay over the threshold (50% + 1) right now.

That said, I think Rod usually likes to have it documented as unanimous, so maybe it's worth it to get the last 4 or 5 people to weigh in?

@jasnell
Copy link
Member

jasnell commented Feb 26, 2017

Oh right, 2/3 is for TSC lol ... we really ought to align those :-)

@rvagg
Copy link
Member Author

rvagg commented Mar 2, 2017

On the agenda for a vote at next week's meeting. We're mostly done with voting here so it's just the formality of doing it in a meeting!

@Trott
Copy link
Member

Trott commented Mar 9, 2017

I missed the meeting today, but this officially passed, right? And @fhinkel (or someone else) can open a PR moving their info in the README to the CTC section?

@jasnell
Copy link
Member

jasnell commented Mar 9, 2017 via email

@Trott Trott removed the ctc-agenda label Mar 9, 2017
@ChALkeR
Copy link
Member

ChALkeR commented Mar 9, 2017

@Trott, this is such a PR. :-)

@Trott
Copy link
Member

Trott commented Mar 9, 2017

@Trott, this is such a PR. :-)

Doh! OK, yeah, landing!

Trott pushed a commit to Trott/io.js that referenced this pull request Mar 9, 2017
PR-URL: nodejs#11488
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Trott
Copy link
Member

Trott commented Mar 9, 2017

Landed in c7e8aff. Hooray! Welcome, @fhinkel! 🎉

@Trott Trott closed this Mar 9, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 13, 2017
PR-URL: nodejs#11488
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
PR-URL: nodejs#11488
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
PR-URL: #11488
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
PR-URL: #11488
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
PR-URL: nodejs/node#11488
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.