doc: update V8 debugger doc to mention --inspect-brk #11495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node now supports the `--inspect-brk` flag, which does the same thing as `--inspect --debug-brk`. One thing that's nice about the new flag is that it uses "inspect" language -- this is a suggested update to the docs.
nodejs-github-bot
added
debugger
doc
cjihrig
approved these changes
Feb 22, 2017
gibfahn
approved these changes
Feb 22, 2017
jasnell
approved these changes
Feb 22, 2017
joshgav
approved these changes
Feb 22, 2017
Trott
reviewed
Feb 22, 2017
| @@ -197,8 +197,8 @@ V8 Inspector can be enabled by passing the `--inspect` flag when starting a | |||
| Node.js application. It is also possible to supply a custom port with that flag, | |||
| e.g. `--inspect=9222` will accept DevTools connections on port 9222. | |||
|
|
|||
| To break on the first line of the application code, provide the `--debug-brk` | |||
| flag in addition to `--inspect`. | |||
| To break on the first line of the application code, pass the `--inspect-brk` | |||
There was a problem hiding this comment.
I'm not going to stop or even slow this PR from landing over this incredibly minor thing I'm about to bring up, but I gotta ask: Why the provide -> pass change? (I think of pass as something you do with arguments, not command-line flags, and so provide feels more correct to me in this context. But I'm not sure if that's my own idiosyncrasy.)
There was a problem hiding this comment.
The paragraph above says "passing the --inspect flag" so I followed its lead.
joyeecheung
approved these changes
Feb 25, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 27, 2017
Node now supports the `--inspect-brk` flag, which does the same thing as `--inspect --debug-brk`. One thing that's nice about the new flag is that it uses "inspect" language -- this is a suggested update to the docs. PR-URL: #11495 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in ec4440a |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 28, 2017
Node now supports the `--inspect-brk` flag, which does the same thing as `--inspect --debug-brk`. One thing that's nice about the new flag is that it uses "inspect" language -- this is a suggested update to the docs. PR-URL: nodejs#11495 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node now supports the
--inspect-brkflag, which does the same thingas
--inspect --debug-brk. One thing that's nice about the new flag isthat it uses "inspect" language -- this is a suggested update to the
docs.
Checklist
Affected core subsystem(s)
doc