Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: fix typo in comments #11503

Closed
wants to merge 1 commit into from
Closed

process: fix typo in comments #11503

wants to merge 1 commit into from

Conversation

levsthings
Copy link
Contributor

Fixing a typo in comments, the word 'remaining' had a typo.
Fixes: #11491

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

process

@levsthings
fix typo in comments
298245b 
Fixing a typo in comments, the word 'remaining' had a typo.
Fixes: #11491
@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Feb 22, 2017
@levsthings levsthings changed the title fix typo in comments process: fix typo in comments Feb 22, 2017
jasnell
jasnell approved these changes Feb 22, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't need to wait the full 48 hours to land

benjamingr
benjamingr approved these changes Feb 23, 2017
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hiroppy
hiroppy approved these changes Feb 25, 2017
View reviewed changes
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hiroppy
Copy link
Member

hiroppy commented Feb 25, 2017

landed in ee7b7f6

@hiroppy hiroppy closed this Feb 25, 2017
hiroppy pushed a commit that referenced this pull request Feb 25, 2017
@levsthings @hiroppy
process: fix typo in comments
ee7b7f6 
Fixing a typo in comments, the word 'remaining' had a typo.

PR-URL: #11503
Fixes: #11491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 27, 2017
@levsthings @italoacasas
process: fix typo in comments
fe7a722 
Fixing a typo in comments, the word 'remaining' had a typo.

PR-URL: nodejs#11503
Fixes: nodejs#11491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 27, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@levsthings @jasnell
process: fix typo in comments
a95851e 
Fixing a typo in comments, the word 'remaining' had a typo.

PR-URL: #11503
Fixes: #11491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@levsthings @MylesBorins
process: fix typo in comments
02e5f5c 
Fixing a typo in comments, the word 'remaining' had a typo.

PR-URL: #11503
Fixes: #11491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@levsthings @hiroppy @jasnell @benjamingr @lpinca @cjihrig @nodejs-github-bot