test-require-resolve: use case insensitive compare #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caineio
added
need info
and removed
wip
piscisaureus
force-pushed
the
fix-test-require-resolve
branch
from
02ad518 to
2db53f4
Compare
The test fixtures dirrectory is derived from the path to the currently running script, which is itself specified on the command line. That means that the case of the fixtures dir may not match what the test expects (when executed on a case-insensitive filesystem).
piscisaureus
force-pushed
the
fix-test-require-resolve
branch
from
2db53f4 to
1dc8eaa
Compare
|
LGTM |
piscisaureus
added a commit
that referenced
this pull request
Dec 9, 2014
The test fixtures directory is derived from the path to the currently running script, which is itself specified on the command line. That means that the case of the fixtures dir may not match what the test expects (when executed on a case-insensitive file system). PR-URL: #116 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Closing. This landed in dd7ce69 |
piscisaureus
added a commit
to piscisaureus/node
that referenced
this pull request
Dec 23, 2014
The test fixtures directory is derived from the path to the currently running script, which is itself specified on the command line. That means that the case of the fixtures dir may not match what the test expects (when executed on a case-insensitive file system). PR-URL: nodejs/node#116 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
piscisaureus
added a commit
to piscisaureus/node
that referenced
this pull request
Dec 23, 2014
The test fixtures directory is derived from the path to the currently running script, which is itself specified on the command line. That means that the case of the fixtures dir may not match what the test expects (when executed on a case-insensitive file system). PR-URL: nodejs/node#116 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
dgozman
pushed a commit
to dgozman/node
that referenced
this pull request
Oct 13, 2020
process: update v8 fast api calls usage This commit removes the WrapperTraits specialization for FastHrtime according to recent changes in the V8 API. Refs: nodejs#33374
This was referenced Aug 17, 2021
This was referenced Sep 27, 2021
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for the issue that f6e5740 had intended to fix.
It's needed because f6e5740 has been reverted in e24fa83.
See also https://github.com/node-forward/node/issues/20 and #100
@indutny or @bnoordhuis, can I get your review on this?
Because node-forward is closed, here's the text:
The patch nodejs/node-v0.x-archive@a05f973 was landed to make some tests pass, but I can't really reconstruct what the motivation was. What I can tell is that the test failure wasn't really related to path.normalize() and path.resolve() [not] changing the drive letter case.
This patch has caused a lot of issues, including nodejs/node-v0.x-archive#7031 and nodejs/node-v0.x-archive#7806 and lots of bikeshedding about whether uppercase is the right case or lowercase.
I propose reverting the offending patch, and just doing what node does everywhere else (which is: path functions don't touch the case) and take another look at the cause of those test failures.