test: fix params in parallel/test-fs-null-bytes.js #11601
Conversation
|
@targos Added. Sorry, maybe I had to post 2 separate issues for these cases. |
|
@seishun what about |
|
@targos I think it's better to follow other tests. For example. |
|
@seishun Done. |
There was a problem hiding this comment.
Functions
fs.appendFile()and fs.writeFile()were called without mandatorydataparameter.
How about:
The functions
fs.appendFile()andfs.writeFile()were called without the requireddataparameter.
Also is that how functions are usually referred to in commit messages, with empty brackets?
This PR adds a simple
dataparameter to 6 calls of these functions.
I don't think this line is necessary, but in any case commit messages don't usually refer to themselves as PRs.
|
@seishun Fixed. As for 'how functions are usually referred to in commit messages' — I don't know. I just followed STYLE_GUIDE here:
Tell me if I should change this here. |
|
Agreed, let's keep the parentheses as-is. Also, maybe "were being called" instead of "were called". And maybe "argument" instead of "parameter". |
|
Could this be landed, please? |
|
@vsemozhetbyt One more thing. The first line is too long. How about replace "params" with "args"? |
The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: #11595
|
@seishun Done. |
The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: #11595 PR-URL: #11601 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land |
The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: #11595 Backport-PR-URL: #12477 PR-URL: #11601 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: #11595 Backport-PR-URL: #12477 PR-URL: #11601 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: nodejs/node#11595 Backport-PR-URL: nodejs/node#12477 PR-URL: nodejs/node#11601 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
fs, test
parallel/test-fs-null-bytes.jstestsfs.appendFile()andfs.writeFile()with wrong parameters scheme, i.e. without mandatorydataparameter. This may be not very important for the test aim, but it makes it somehow compromised. This PR adds a simpledataparameter to the 6 calls of these functions.