-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: exclude pseudo-tty test pertinent to #11541 #11602
test: exclude pseudo-tty test pertinent to #11541 #11602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestion
test/pseudo-tty/pseudo-tty.status
Outdated
no_interleaved_stdio : SKIP | ||
no_dropped_stdio : SKIP | ||
no_interleaved_stdio : SKIP | ||
test-stderr-stdout-handle-sigwinch : SKIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment to the line above:
# Test issue: https://github.com/nodejs/node/issues/11541
test-stderr-stdout-handle-sigwinch : SKIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gibfahn - applied the changes as suggested, thanks.
cc/ @nodejs/platform-aix |
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green.
3b26e8a
to
2869949
Compare
I still think we should just mark them all as flaky on AIX. Clearly something outside of our direct control does not work correctly here. |
@Fishrock123 - thanks for the suggestion, and agree that we see a pattern of failures affecting AIX. But I guess the pattern is well understood (for this test as well as couple of others) as the race condition between the parent and child with respect to the message passing. Shall we wait until I address the race condition, and see how the tests are faring, before we re-assess the AIX scenario? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green. PR-URL: #11602 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
landed in 3b11d89 |
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green. PR-URL: #11602 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This test pseudo-tty/test-stderr-stdout-handle-sigwinch is newly added
to v4.x stream and is consistently failing.
We have a couple of issues with pseudo-tty tests in AIX, and while
the investigation is going on, need to skip this test to make CI green.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)