Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: exclude pseudo-tty test pertinent to #11541 #11602

Closed

Conversation

gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Feb 28, 2017

This test pseudo-tty/test-stderr-stdout-handle-sigwinch is newly added
to v4.x stream and is consistently failing.

We have a couple of issues with pseudo-tty tests in AIX, and while
the investigation is going on, need to skip this test to make CI green.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestion

no_interleaved_stdio : SKIP
no_dropped_stdio : SKIP
no_interleaved_stdio : SKIP
test-stderr-stdout-handle-sigwinch : SKIP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment to the line above:

# Test issue: https://github.com/nodejs/node/issues/11541
test-stderr-stdout-handle-sigwinch    : SKIP

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibfahn - applied the changes as suggested, thanks.

@gibfahn gibfahn added the aix Issues and PRs related to the AIX platform. label Feb 28, 2017
@gibfahn
Copy link
Member

gibfahn commented Feb 28, 2017

cc/ @nodejs/platform-aix

@mscdex mscdex added the tty Issues and PRs related to the tty subsystem. label Feb 28, 2017
This test is newly added to v4.x stream and is consistently failing.
We have a couple of issues with pseudo-tty tests in AIX, and while
the investigation is going on, need to skip this test to make CI green.
@Fishrock123
Copy link
Contributor

I still think we should just mark them all as flaky on AIX. Clearly something outside of our direct control does not work correctly here.

@gireeshpunathil
Copy link
Member Author

@Fishrock123 - thanks for the suggestion, and agree that we see a pattern of failures affecting AIX. But I guess the pattern is well understood (for this test as well as couple of others) as the race condition between the parent and child with respect to the message passing. Shall we wait until I address the race condition, and see how the tests are faring, before we re-assess the AIX scenario?

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Mar 2, 2017

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Mar 3, 2017
This test is newly added to v4.x stream and is consistently failing.
We have a couple of issues with pseudo-tty tests in AIX, and while
the investigation is going on, need to skip this test to make CI green.

PR-URL: #11602
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 3b11d89

@MylesBorins MylesBorins closed this Mar 3, 2017
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
This test is newly added to v4.x stream and is consistently failing.
We have a couple of issues with pseudo-tty tests in AIX, and while
the investigation is going on, need to skip this test to make CI green.

PR-URL: #11602
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants