build: add node_use_openssl check to install.py #11766
Conversation
nodejs-github-bot
added
the
build
|
I'm confused about this. Why should we not allow compiling without OpenSSL? |
Sorry for the confusion. This is not really about comping without OpenSSL but after doing so running make install will copy the OpenSSL headers into the target installation directory which I was not expecting. I know I added two checks to this commit but wanted to get some feedback and perhaps just having a check in tools/install would be enough. Or close this as this might not really effect real use cases (I only noticed because I was testing) but thought I would be worth bringing up at least. |
|
Don't the current changes to the configure script prevent users from compiling entirely without OpenSSL though? |
Yes, the change to configure does force that. How about I remove that check and leave the one in tools/install.py? |
|
That sounds good to me. AFAIK that extra check in tools/install.py should be all that's needed. |
Great, thanks for that and sorry about the confusion! |
When configuring --without-ssl and then running make install openssl headers will be copied from deps/openssl to the target installation directory. This commit adds a check for is node_use_openssl is set in which case the headers are not copied.
danbev
force-pushed
the
check-without-ssl-and-shared-openssl
branch
from
1739500 to
5de9bc6
Compare
|
Rebased and clarified commit title and message. |
danbev
changed the title
configure
Outdated
| @@ -975,7 +975,6 @@ def configure_openssl(o): | |||
| else: | |||
| o['variables']['openssl_fips'] = '' | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Unrelated whitespace change.
There was a problem hiding this comment.
Sorry that was sloppy of me. Fix it now. Thanks
|
@mscdex Thanks for the review! Would you like to approve this and I can add you to the list of reviewers? |
|
LGTM |
When configuring --without-ssl and then running make install openssl headers will be copied from deps/openssl to the target installation directory. This commit adds a check for is node_use_openssl is set in which case the headers are not copied. PR-URL: nodejs#11766 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in 471aa19 |
When configuring --without-ssl and then running make install openssl headers will be copied from deps/openssl to the target installation directory. This commit adds a check for is node_use_openssl is set in which case the headers are not copied. PR-URL: nodejs#11766 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net>
When configuring --without-ssl and then running make install openssl headers will be copied from deps/openssl to the target installation directory. This commit adds a check for is node_use_openssl is set in which case the headers are not copied. PR-URL: nodejs#11766 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net>
When configuring --without-ssl and then running make install openssl headers will be copied from deps/openssl to the target installation directory. This commit adds a check for is node_use_openssl is set in which case the headers are not copied. PR-URL: #11766 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net>
When configuring --without-ssl and then running make install openssl headers will be copied from deps/openssl to the target installation directory. This commit adds a check for is node_use_openssl is set in which case the headers are not copied. PR-URL: #11766 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net>
When configuring --without-ssl and then running make install openssl headers will be copied from deps/openssl to the target installation directory. This commit adds a check for is node_use_openssl is set in which case the headers are not copied. PR-URL: nodejs/node#11766 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net>
When configuring --without-ssl and then running make install
openssl headers will be copied from deps/openssl to the target
installation directory.
This commit adds a check for is node_use_openssl is set in which
case the headers are not copied.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build