Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-util-inspect.js #11779

Closed
wants to merge 1 commit into from
Closed

test: refactor test-util-inspect.js #11779

wants to merge 1 commit into from

Commits on Mar 10, 2017

  1. test: refactor test-util-inspect.js 

    * Enclose tests that used to introduce module-level variables into
  their own scopes.
* Replace ES5 anonymous functions with arrow functions where it makes
  sense.
* And make one arrow function a regular function thus fixing a bug in a
  getter inside an object created in "Array with dynamic properties"
  test.  This getter has never been invoked though, so the test hasn't been
  failing.
* Convert snake_case identifiers to camelCase.
* Make some variable names more readable.
* Replace regular expressions in maxArrayLength tests with simple
  assert.strictEquals() and assert(...endsWith()) checks, as suggested
  in <nodejs#11576 (comment)>.
    @aqrln
    aqrln committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    fc23c8d View commit details
    Browse the repository at this point in the history