benchmark: add final clean-up to module-loader.js #11924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
benchmark
cjihrig
approved these changes
Mar 19, 2017
jasnell
approved these changes
Mar 20, 2017
jasnell
pushed a commit
that referenced
this pull request
Mar 22, 2017
PR-URL: #11924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in ae8a869 |
|
this will need to be manually backported to v7.x |
2 tasks
|
@MylesBorins Done: #12102 |
3 tasks
|
@vsemozhetbyt, I landed 211dd16 on v6.x-staging, let me know if that was a mistake. |
|
@gibfahn I cannot imagine any cause this can be wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark, module
Currently,
module-loader.jscleans up its temp directory only before each benchmark run. So after the last run, atmpdirectory with 50,000 subdirectories and 100,000 files remains in thebenchmarkdirectory. A second final clean-up does not add much more time to overall benchmark duration because it reduces the time for each next initialization, whilebenchmarkdirectory remains clean after the last run.