test: invalid chars in http client path #11964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucamaraschi
force-pushed
the
test-http-invalid-path-chars
branch
from
2424b76 to
ae7cdbe
Compare
cjihrig
requested changes
Mar 21, 2017
| const server = http.createServer((req, res) => { | ||
| res.end(); | ||
| server.close(); | ||
| }).listen(0, test); |
There was a problem hiding this comment.
Can you add common.mustCall() around the callback.
cjihrig
approved these changes
Mar 21, 2017
|
I think it would be better to try a path string for each control character instead of all of them together. Also, I don't think we need to spin up a server just to check for the |
|
Definitely agree with @mscdex. Testing each individually would be more robust. |
This test adds coverage for all the characters which are considered invalid in a http path.
lucamaraschi
force-pushed
the
test-http-invalid-path-chars
branch
from
729b3d9 to
f9c57fe
Compare
lpinca
approved these changes
Mar 23, 2017
jasnell
approved these changes
Mar 23, 2017
|
extremely minor nit: for the "experimentally" determined number, it may be useful to include a comment that describes the process you followed to find that number :-) |
|
I guess the comment should be added here Line 108 in ee19e29 |
cjihrig
approved these changes
Mar 23, 2017
jasnell
pushed a commit
that referenced
this pull request
Mar 24, 2017
This test adds coverage for all the characters which are considered invalid in a http path. PR-URL: #11964 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 30f1e8e |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
This test adds coverage for all the characters which are considered invalid in a http path. PR-URL: #11964 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
This test adds coverage for all the characters which are considered invalid in a http path. PR-URL: #11964 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
This test adds coverage for all the characters which are considered invalid in a http path. PR-URL: #11964 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
This test adds coverage for all the characters which are considered invalid in a http path. PR-URL: nodejs/node#11964 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test adds coverage for all the characters which are considered
invalid in a http path.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test http-client