Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update collaborator email address #11996

Closed
wants to merge 1 commit into from
Closed

doc: update collaborator email address #11996

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 22, 2017

Per email conversation with Shigeki Ohtsu, updating email address in
docs. The current listed email address does not work anymore.

Checklist
Affected core subsystem(s)

doc

@Trott Trott added the doc Issues and PRs related to the documentations. label Mar 22, 2017
@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. labels Mar 22, 2017
@Trott Trott requested a review from shigeki March 22, 2017 23:14
@Trott
doc: update collaborator email address
3873ea0 
Per email conversation with Shigeki Ohtsu, updating email address in
docs. The current listed email address does not work anymore.
@Trott Trott removed the libuv Issues and PRs related to the libuv dependency or the uv binding. label Mar 22, 2017
addaleax
addaleax approved these changes Mar 22, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nodejs/email too, I assume?

@Trott
Copy link
Member Author

Trott commented Mar 23, 2017

@addaleax wrote:

https://github.com/nodejs/email too, I assume?

Yes: nodejs/email#37

shigeki
shigeki approved these changes Mar 23, 2017
View reviewed changes
Copy link
Contributor

@shigeki shigeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. I missed it.

@jasnell
Copy link
Member

jasnell commented Mar 23, 2017

This should not need the 48 hours to land

@shigeki
Copy link
Contributor

shigeki commented Mar 23, 2017

I'll land this. After rubber stamping of CI result in https://ci.nodejs.org/job/node-test-commit/8628/.

shigeki pushed a commit that referenced this pull request Mar 23, 2017
@Trott @shigeki
doc: update collaborator email address
8a639bb 
Per email conversation with Shigeki Ohtsu, updating email address in
docs. The current listed email address does not work anymore.

PR-URL: #11996
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@shigeki
Copy link
Contributor

shigeki commented Mar 23, 2017

All is green. Landed in 8a639bb. Thanks.

@shigeki shigeki closed this Mar 23, 2017
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@Trott @MylesBorins
doc: update collaborator email address
924f346 
Per email conversation with Shigeki Ohtsu, updating email address in
docs. The current listed email address does not work anymore.

PR-URL: #11996
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@Trott @MylesBorins
doc: update collaborator email address
d5f9390 
Per email conversation with Shigeki Ohtsu, updating email address in
docs. The current listed email address does not work anymore.

PR-URL: #11996
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@Trott @MylesBorins
doc: update collaborator email address
aab9526 
Per email conversation with Shigeki Ohtsu, updating email address in
docs. The current listed email address does not work anymore.

PR-URL: #11996
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@Trott @andrew749
doc: update collaborator email address
e285d51 
Per email conversation with Shigeki Ohtsu, updating email address in
docs. The current listed email address does not work anymore.

PR-URL: nodejs/node#11996
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@Trott Trott deleted the update-email branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@shigeki shigeki shigeki approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @shigeki @addaleax @MylesBorins @nodejs-github-bot