deps: cherry-pick 22858cb from V8 upstream #11998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message: Only flush not yet started and finished compile jobs from gc We shouldn't block during GC for arbitrarily long intervals. BUG=chromium:686153,chromium:642532 R=verwaest@chromium.org,hpayer@chromium.org Review-Url: https://codereview.chromium.org/2658313002 Cr-Commit-Position: refs/heads/master@{nodejs#42761}
nodejs-github-bot
added
v7.x
v8 engine
bnoordhuis
approved these changes
Mar 23, 2017
targos
approved these changes
Mar 23, 2017
jasnell
approved these changes
Mar 23, 2017
Paging @jeisinger as the original author of the upstream change. |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
Original commit message: Only flush not yet started and finished compile jobs from gc We shouldn't block during GC for arbitrarily long intervals. BUG=chromium:686153,chromium:642532 R=verwaest@chromium.org,hpayer@chromium.org Review-Url: https://codereview.chromium.org/2658313002 Cr-Commit-Position: refs/heads/master@{nodejs#42761} PR-URL: nodejs#11998 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in |
|
@ofrobots should this land on v6.x? |
|
sorry, didn't see the question before. Yes, the first Unblock() call can be moved into the if () block below. However, blocking concurrent recompilation is a unit test support feature, so it doesn't really matter that much.. |
|
@MylesBorins no, this is not relevant to 6.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
This is needed on
v7.x(V8 5.5). It is already merged to 5.6 and 5.7.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps:v8
R=@nodejs/v8
EDIT:
CI: https://ci.nodejs.org/job/node-test-pull-request/6990/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/618/