Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add .FromJust(), fix -Wunused-result warnings #12118

Closed
wants to merge 1 commit into from
Closed

src: add .FromJust(), fix -Wunused-result warnings #12118

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.")

@bnoordhuis
src: add .FromJust(), fix -Wunused-result warnings
a4c152d 
Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.")
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 29, 2017
@mscdex mscdex added lib / src Issues and PRs related to general changes in the lib or src directory. v8 engine Issues and PRs related to the V8 dependency. labels Mar 29, 2017
@addaleax
Copy link
Member

Landed in 7c0079f

@addaleax addaleax closed this Mar 31, 2017
addaleax pushed a commit that referenced this pull request Mar 31, 2017
@bnoordhuis @addaleax
src: add .FromJust(), fix -Wunused-result warnings
7c0079f 
Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.")

PR-URL: #12118
Refs: #11048
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bnoordhuis @addaleax @danbev @jasnell @targos @cjihrig @mscdex @italoacasas @nodejs-github-bot