Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add logo to README #12148

Closed
wants to merge 2 commits into from
Closed

doc: add logo to README #12148

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a4f13d
doc: add logo to README
silverwind Mar 31, 2017
07ef63b
add alt attribute and remove link from logo
silverwind Apr 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Node.js

[![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/nodejs/node?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) [![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/29/badge)](https://bestpractices.coreinfrastructure.org/projects/29)
<p align="center">
<a href="https://nodejs.org/">
<img src="https://nodejs.org/static/images/logo-light.svg" width="400" />
Copy link
Member

@TimothyGu TimothyGu Mar 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alt attribute seems appropriate here for screen readers (ditto below).

Copy link
Member

@Trott Trott Apr 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, should have an alt attribute and it should probably be empty: alt=""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not alt="Node.js logo"?

Copy link
Member

@Trott Trott Apr 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should follow guidance of things like http://webaim.org/techniques/alttext/#logos. "Node.js home page" is probably what we want per that doc. Specifically, the alt text should likely not contain the word "logo".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll just go with alt="Node.js" and remove the link on the logo as there are already multiple links in the document that link to the homepage.

</a>
</p>
<p align="center">
<a title="Gitter" href="https://gitter.im/nodejs/node?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge"><img src="https://badges.gitter.im/Join%20Chat.svg"></a>
<a title="CII Best Practices" href="https://bestpractices.coreinfrastructure.org/projects/29"><img src="https://bestpractices.coreinfrastructure.org/projects/29/badge"></a>
</p>

Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine. Node.js
uses an event-driven, non-blocking I/O model that makes it lightweight and
Expand Down