Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc, inspector: note that the host is optional #12149

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Mar 31, 2017

Document that node --inspect=${port} is also a viable option.

Checklist
Affected core subsystem(s)

doc
[commit guidelines]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines

EDIT: CI: https://ci.nodejs.org/job/node-test-commit/8834/

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 31, 2017
@mscdex mscdex added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol and removed c++ Issues and PRs that require attention from people who are familiar with C++. labels Mar 31, 2017
Document that `node --inspect=${port}` is also a viable option.

PR-URL: nodejs#12149
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn merged commit 2d2970e into nodejs:master Apr 4, 2017
@gibfahn gibfahn deleted the inspect-docs branch April 4, 2017 09:29
@jasnell jasnell mentioned this pull request Apr 4, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
Document that `node --inspect=${port}` is also a viable option.

PR-URL: nodejs#12149
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
2 tasks
@MylesBorins
Copy link
Contributor

is this true for the v6 inspector?

@gibfahn
Copy link
Member Author

gibfahn commented Apr 19, 2017

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants