Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add sub domain to host in url #12233

Closed
wants to merge 2 commits into from
Closed

doc: add sub domain to host in url #12233

wants to merge 2 commits into from

Conversation

styfle
Copy link
Member

@styfle styfle commented Apr 5, 2017 •
edited
Loading

This change is to better illustrate what happens to the sub domain when parsing a URL.

Checklist
Affected core subsystem(s)
  • doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Apr 5, 2017
@styfle styfle changed the title doc: add sub domain to host doc: add sub domain to host in WHATWG URL Apr 5, 2017
TimothyGu
TimothyGu suggested changes Apr 5, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple more places you need to change:

@styfle
Copy link
Member Author

styfle commented Apr 5, 2017

@TimothyGu Thanks, I can't believe I missed that!

I went ahead and changed all host.com to sub.host.com.

@vsemozhetbyt vsemozhetbyt added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Apr 5, 2017
@mscdex mscdex removed the url Issues and PRs related to the legacy built-in url module. label Apr 5, 2017
@TimothyGu TimothyGu changed the title doc: add sub domain to host in WHATWG URL doc: add sub domain to host in url Apr 5, 2017
@TimothyGu TimothyGu added the url Issues and PRs related to the legacy built-in url module. label Apr 5, 2017
@TimothyGu
Copy link
Member

Landed in 9acd6c9.

@TimothyGu TimothyGu closed this Apr 7, 2017
TimothyGu pushed a commit that referenced this pull request Apr 7, 2017
@styfle @TimothyGu
doc: add sub domain to host in url
9acd6c9 
PR-URL: #12233
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
@styfle @italoacasas
doc: add sub domain to host in url
2fb2289 
PR-URL: nodejs#12233
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
@styfle styfle deleted the patch-1 branch October 11, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@styfle @TimothyGu @jasnell @lpinca @cjihrig @vsemozhetbyt @mscdex @MylesBorins @nodejs-github-bot