Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add aqrln to collaborators #12273

Closed
wants to merge 1 commit into from
Closed

Conversation

aqrln
Copy link
Contributor

@aqrln aqrln commented Apr 7, 2017

Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

Checklist
Affected core subsystem(s)

doc

Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 7, 2017
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome aboard!

@aqrln
Copy link
Contributor Author

aqrln commented Apr 7, 2017

@aqrln aqrln force-pushed the add-collaborator branch from 6200abe to 81fd8b4 Compare April 7, 2017 16:26
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aqrln
Copy link
Contributor Author

aqrln commented Apr 7, 2017

Sorry, had to force-push and restart the CI because of invalid order in the list (used to be sorted by the name instead of the GitHub handle).

New CI: https://ci.nodejs.org/job/node-test-pull-request/7269/

Trott pushed a commit to Trott/io.js that referenced this pull request Apr 7, 2017
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: nodejs#12273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aqrln
Copy link
Contributor Author

aqrln commented Apr 7, 2017

Landed in 6581c35.

@aqrln aqrln closed this Apr 7, 2017
@aqrln aqrln deleted the add-collaborator branch April 7, 2017 17:30
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 9, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: nodejs#12273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: #12273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: #12273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: nodejs/node#12273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants