-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add cwd ENOENT known issue test #12343
Conversation
common.refreshTmpDir(); | ||
const dir = fs.mkdtempSync(common.tmpDir + '/'); | ||
process.chdir(dir); | ||
fs.rmdirSync(dir); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will probably have to skip on Windows like the other cwd enoent test does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passes
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Refs: nodejs#12022 PR-URL: nodejs#12343 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This is failing lint on v7.x. Mind submitting a backport PR? |
@evanlucas is this failing via the test runner, or failing if you run the test on its own? It's a known issue test, so it should fail. |
It is failing
|
Ah, this probably depends on #12293 then. |
Don't need backport to 7.x, and its already in 8.x |
Should land with #12293 if that lands. |
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Refs: nodejs#12022 PR-URL: nodejs#12343 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Backport-PR-URL: #15479 Refs: #12022 PR-URL: #12343 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Backport-PR-URL: #15479 Refs: #12022 PR-URL: #12343 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
If the current working directory is removed, Node cannot start normally because the module system calls
uv_cwd()
.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test