Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix recommendation to use useless config #12445

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: correct git fix whitespace command
Old config instruction instructed people to enable option that does not exist and is silently ignored by git
Refs: #11412
  • Loading branch information
matkoniecz committed Apr 17, 2017
commit 1e12c7396809e67de738b888d813301fb29f9efa
2 changes: 1 addition & 1 deletion doc/onboarding.md
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ onboarding session.
## Local setup

* git:
* make sure you have whitespace=fix: `git config --global --add core.whitespace fix`
* make sure you have whitespace=fix: `git config --global --add apply.whitespace fix`
* usually PR from your own github fork
* [See "Updating Node.js from Upstream"](./onboarding-extras.md#updating-nodejs-from-upstream)
* make new branches for all commits you make!