Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: unify quotes in an assert.md code example #12505

Closed
wants to merge 1 commit into from
Closed

doc: unify quotes in an assert.md code example #12505

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, assert

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Apr 19, 2017
@danbev
Copy link
Contributor

danbev commented Apr 19, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7504/

cjihrig
cjihrig approved these changes Apr 19, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to sit for 48 hours.

@vsemozhetbyt
Copy link
Contributor Author

Landed in 211813c

@vsemozhetbyt vsemozhetbyt deleted the assert.md-quotes branch April 19, 2017 14:42
vsemozhetbyt added a commit that referenced this pull request Apr 19, 2017
@vsemozhetbyt
doc: unify quotes in an assert.md code example
211813c 
PR-URL: #12505
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 18, 2017

Fixes #11128 which is semver-major, so marking dont-land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

@jseijas jseijas jseijas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@vsemozhetbyt @danbev @gibfahn @thefourtheye @benjamingr @lpinca @cjihrig @jseijas @DavidCai1111 @nodejs-github-bot