Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove TODO about uv errno removal #12536

Closed
wants to merge 3 commits into from
Closed

src: remove TODO about uv errno removal #12536

wants to merge 3 commits into from
+0 −2

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 20, 2017 •
edited
Loading

This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion.

Refs: #4641

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: remove uv errno
fe0b8d9 
This commit attempts to take care of a TODO reported in issue 4641.
I'm not sure if just removing errno is an option, as there might be
code that is depending on this errno being availble. If it cannot be
removed perhaps the TODO can. Hopefully feedback on this commit will
sort that out.

Refs: nodejs#4641
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 20, 2017
@danbev
Copy link
Contributor Author

danbev commented Apr 20, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7550/

@cjihrig cjihrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 20, 2017
@Fishrock123
Copy link
Contributor

This is documented publicly here, and definitely used in the wild. -1 on removing it, it is useful.

@cjihrig
Copy link
Contributor

cjihrig commented Apr 20, 2017

If we don't remove it, let's get rid of that TODO :-)

@jasnell
Copy link
Member

jasnell commented Apr 20, 2017

Yeah, let's definitely not remove it. There are several uses of it that I'm aware of that would cause significant breakage.

@danbev
Copy link
Contributor Author

danbev commented Apr 20, 2017

@Fishrock123 @jasnell I suspected this would be the case. Can we remove the TODO like @cjihrig mentioned?

danbev added 2 commits April 20, 2017 20:20
@danbev
Revert "src: remove uv errno"
8d40cdc 
This reverts commit fe0b8d9.
@danbev
src: remove TODO about uv errno removal
c93e1ea 
This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.
@danbev danbev changed the title src: remove uv errno src: remove TODO about uv errno removal Apr 20, 2017
jasnell
jasnell approved these changes Apr 21, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not need to wait the 48 hours to land

jasnell pushed a commit that referenced this pull request Apr 21, 2017
@danbev @jasnell
src: remove TODO about uv errno removal
bde26a6 
This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.

PR-URL: #12536
Ref: #4641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 21, 2017

Landed in bde26a6

@jasnell jasnell closed this Apr 21, 2017
@sam-github sam-github removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 24, 2017
@gibfahn
Copy link
Member

gibfahn commented Apr 24, 2017 •
edited
Loading

I think this is no longer semver-major

evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@danbev @evanlucas
src: remove TODO about uv errno removal
56530c1 
This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.

PR-URL: #12536
Ref: #4641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@danbev @evanlucas
src: remove TODO about uv errno removal
3b1594a 
This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.

PR-URL: #12536
Ref: #4641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@danbev @evanlucas
src: remove TODO about uv errno removal
184941e 
This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.

PR-URL: #12536
Ref: #4641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@danbev @gibfahn
src: remove TODO about uv errno removal
e9cee1a 
This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.

PR-URL: #12536
Ref: #4641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@danbev @MylesBorins
src: remove TODO about uv errno removal
b296bd5 
This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.

PR-URL: #12536
Ref: #4641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
@danbev danbev deleted the remove-errno branch June 28, 2017 05:38
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@danbev @andrew749
src: remove TODO about uv errno removal
f0beca1 
This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.

PR-URL: nodejs/node#12536
Ref: nodejs/node#4641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@danbev @Fishrock123 @cjihrig @jasnell @gibfahn @addaleax @sam-github @nodejs-github-bot