test: make tests pass when built without inspector #12622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Apr 24, 2017
bnoordhuis
approved these changes
Apr 24, 2017
test/common.js
Outdated
| if (!exports.hasCrypto) { | ||
| exports.skip('missing ssl support so inspector is disabled'); | ||
| if (!exports.hasCrypto || | ||
| process.config.variables.v8_enable_inspector === 0) { |
There was a problem hiding this comment.
The !exports.hasCrypto check should be superfluous now.
targos
force-pushed
the
tests-without-inspector
branch
from
8376136 to
2fb6f1a
Compare
gibfahn
approved these changes
Apr 24, 2017
jasnell
approved these changes
Apr 24, 2017
|
Landed in c8c5a52. |
targos
added a commit
that referenced
this pull request
Apr 26, 2017
PR-URL: #12622 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, inspector