test: fixup test-http-hostname-typechecking #12627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI: https://ci.nodejs.org/job/node-test-pull-request/7655/ I’d be very okay with fast-tracking to unbreak master. |
addaleax
force-pushed
the
fix-http-master
branch
from
77b9eb3 to
450014a
Compare
lpinca
reviewed
Apr 25, 2017
| // These values are OK and should not throw synchronously | ||
| ['', undefined, null].forEach((v) => { | ||
| assert.doesNotThrow(() => { | ||
| http.request({hostname: v}).on('error', common.noop); | ||
| http.request({host: v}).on('error', common.noop); | ||
| reqs.push(http.request({hostname: v}).on('error', common.noop)); |
There was a problem hiding this comment.
Nit: any reason for preferring this over a simple .end() on the original version?
There was a problem hiding this comment.
@lpinca See @jasnell’s comment in #12494 (comment) … I tried to keep this bit of the test just testing what it’s supposed to. Personally, I would totally be fine with having .end() here.
There was a problem hiding this comment.
@addaleax not sure I understand.
http.request({hostname: v}).on('error', common.noop).end();would still work as intended no? The error event would still be emitted. It should only check that it doesn't throw synchronously.
danbev
approved these changes
Apr 25, 2017
addaleax
force-pushed
the
fix-http-master
branch
from
450014a to
9c38c47
Compare
This test would currently create HTTP requests to localhost:80 and would time out on machines that actually had an server listening there. To address that, `end()` the requests that are generated. PR-URL: nodejs#12627 Ref: nodejs#12494
addaleax
force-pushed
the
fix-http-master
branch
from
9c38c47 to
0229581
Compare
lpinca
approved these changes
Apr 25, 2017
cjihrig
approved these changes
Apr 25, 2017
|
Lgtm |
|
Landed in 28f535a |
addaleax
added a commit
that referenced
this pull request
Apr 27, 2017
This test would currently create HTTP requests to localhost:80 and would time out on machines that actually had an server listening there. To address that, `end()` the requests that are generated. PR-URL: #12627 Ref: #12494 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
|
Depends on #12494 which is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test would currently create HTTP requests to localhost:80
and would time out on machines that actually had an server listening
there.
To address that,
end()the requests that are generated./cc @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test