Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove invalid comment #12645

Merged
merged 1 commit into from
Apr 25, 2017
Merged

src: remove invalid comment #12645

merged 1 commit into from
Apr 25, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 25, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 25, 2017
jasnell
jasnell approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shouldn't need to wait 48 hours to land

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 25, 2017

Overly cautious CI: https://ci.nodejs.org/job/node-test-pull-request/7674/

@cjihrig
src: remove invalid comment
a334c5b 
PR-URL: nodejs#12645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@cjihrig cjihrig merged commit a334c5b into nodejs:master Apr 25, 2017
@cjihrig cjihrig deleted the comment branch April 25, 2017 19:02
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@cjihrig @evanlucas
src: remove invalid comment
1f96d77 
PR-URL: #12645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@cjihrig @evanlucas
src: remove invalid comment
da01ff7 
PR-URL: #12645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@cjihrig @gibfahn
src: remove invalid comment
604e485 
PR-URL: #12645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@cjihrig @MylesBorins
src: remove invalid comment
ce795ec 
PR-URL: #12645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@cjihrig @andrew749
src: remove invalid comment
ad4e806 
PR-URL: nodejs/node#12645
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @danbev @jasnell @addaleax @gibfahn @nodejs-github-bot