-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify arch support for power platforms #12679
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add specifics as to the level of hardware supported for power platforms. Power 8 is the first processor level to support ppc little endian. Set the minimum level for AIX to Power7 for Node version 8 and later. This will allow the potential to leverage new instructions and optimizations going forward. We have spoken to the AIX team and they agree this makes sense. Earlier processor levels will continue to be supported for version 4.x and 6.x on AIX.
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
doc
Issues and PRs related to the documentations.
labels
Apr 26, 2017
cjihrig
approved these changes
Apr 27, 2017
jasnell
approved these changes
Apr 27, 2017
gibfahn
suggested changes
Apr 27, 2017
BUILDING.md
Outdated
| GNU/Linux | Tier 2 | kernel >= 3.13.0, glibc >= 2.19 | ppc64le | | | ||
| AIX | Tier 2 | >= 7.1 TL04 | ppc64be | | | ||
| GNU/Linux | Tier 2 | kernel >= 3.13.0, glibc >= 2.19 | ppc64le, >=power8 | | | ||
| AIX | Tier 2 | >= 7.1 TL04 | ppc64be, >=power7 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can you remove the commas, elsewhere they seem to be used as or (x64, arm
= x64 or arm, ppc64le >=power8
means ppc64le and power8)?
ppc64le, >=power8
-> ppc64le >=power8
ppc64be, >=power7
-> ppc64be >=power7
@gibfahn pushed change to address comments. |
gibfahn
approved these changes
Apr 28, 2017
richardlau
approved these changes
Apr 28, 2017
Landed in 71911be |
gibfahn
pushed a commit
that referenced
this pull request
Apr 28, 2017
Add specifics as to the level of hardware supported for power platforms. Power 8 is the first processor level to support ppc little endian. Set the minimum level for AIX to Power7 for Node version 8 and later. This will allow the potential to leverage new instructions and optimizations going forward. We have spoken to the AIX team and they agree this makes sense. Earlier processor levels will continue to be supported for version 4.x and 6.x on AIX. PR-URL: #12679 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
3 tasks
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add specifics as to the level of hardware supported for
power platforms. Power 8 is the first processor level to
support ppc little endian. Set the minimum level
for AIX to Power7 for Node version 8 and later.
This will allow the potential to leverage new instructions
and optimizations going forward. We have spoken to the
AIX team and they agree this makes sense. Earlier processor
levels will continue to be supported for version 4.x and 6.x
on AIX.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
doc