Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src: fix delete operator on vm context" #12721

Closed
wants to merge 1 commit into from
Closed

Revert "src: fix delete operator on vm context" #12721

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

This reverts commit 587857e. It was found to have subtle
behavior changes

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@MylesBorins
Revert "src: fix delete operator on vm context"
8efd42a 
This reverts commit 587857e. It was found to have subtle
behavior changes
@MylesBorins MylesBorins requested a review from fhinkel April 28, 2017 11:05
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v6.x vm Issues and PRs related to the vm subsystem. labels Apr 28, 2017
@jasnell
Copy link
Member

jasnell commented Apr 28, 2017

LGTM but can you describe or link to a description of what those behavior changes are? :-)

@fhinkel
Copy link
Member

fhinkel commented Apr 28, 2017

We introduced the following change in 7: When we delete an object on the sandbox, we also delete it on the current global proxy. This got accidently ported to 6.x and is reverted here.

LGTM.

MylesBorins added a commit that referenced this pull request Apr 29, 2017
@MylesBorins
Revert "src: fix delete operator on vm context"
f919807 
This reverts commit 587857e. It was found to have subtle
behavior changes in deleting objects.

PR-URL: #12721
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins
Copy link
Contributor Author

Landed in f919807

MylesBorins added a commit that referenced this pull request Apr 29, 2017
@MylesBorins
Revert "src: fix delete operator on vm context"
bed6acb 
This reverts commit 587857e. It was found to have subtle
behavior changes in deleting objects.

PR-URL: #12721
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 29, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@MylesBorins @andrew749
Revert "src: fix delete operator on vm context"
a8107a3 
This reverts commit 587857e. It was found to have subtle
behavior changes in deleting objects.

PR-URL: nodejs/node#12721
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 1, 2017
Closed
@MylesBorins MylesBorins deleted the revert-vm-fix branch November 14, 2017 17:45
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
Open
@aliscco aliscco mentioned this pull request Dec 25, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Jan 3, 2024
Open
@leonardoadame leonardoadame mentioned this pull request May 13, 2024
Open
This was referenced May 14, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MylesBorins @jasnell @fhinkel @nodejs-github-bot