meta: fix nits in README.md collaborators list #12866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
added
the
meta
|
@imran-iq Does your e-mail remain the same? |
lpinca
approved these changes
May 6, 2017
addaleax
approved these changes
May 6, 2017
README.md
Outdated
| @@ -278,7 +278,7 @@ more information about the governance of the Node.js project, see | |||
| **Isaac Z. Schlueter** <i@izs.me> | |||
| * [italoacasas](https://github.com/italoacasas) - | |||
| **Italo A. Casas** <me@italoacasas.com> (he/him) | |||
| * [iWuzHere](https://github.com/iWuzHere) - | |||
| * [imran-iq](https://github.com/imran-iq) - | |||
There was a problem hiding this comment.
I think you might want to re-order these alphabetically :)
gibfahn
approved these changes
May 6, 2017
jasnell
approved these changes
May 7, 2017
|
I am not sure to land this without @Fishrock123, @Qard, @imran-iq showing up. |
|
I'm happy either way on casing of my name. 👍 |
I think this is probably fine to land. |
|
Landed in: dd06246 |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
PR-URL: nodejs#12866 Fixes: nodejs#12865 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
meta
Fixes: #12865
cc @Fishrock123, @Qard, @imran-iq