Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: Revert throw on invalid callbacks #12976

Merged
merged 1 commit into from
May 20, 2017
Merged

fs: Revert throw on invalid callbacks #12976

merged 1 commit into from
May 20, 2017

Commits on May 20, 2017

  1. fs: Revert throw on invalid callbacks 

    This reverts 4cb5f3d

Based on community feedback I think we should consider reverting this
change. We should explore how this could be solved via linting rules.

Refs: #12562
PR-URL: #12976
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @MylesBorins
    MylesBorins committed May 20, 2017
    Configuration menu
    Copy the full SHA
    8250bfd View commit details
    Browse the repository at this point in the history