Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve N-API test coverage #13006

Closed
wants to merge 1 commit into from
Closed

test: improve N-API test coverage #13006

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

add tests top cover functions that returns globals

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, n-api

@mhdawson
test: improve N-API test coverage
bd54759 
add tests top cover functions that returns globals
@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels May 12, 2017
@mhdawson
Copy link
Member Author

CI Run: https://ci.nodejs.org/job/node-test-pull-request/8091/

@mhdawson
Copy link
Member Author

CI good, landing.

@mhdawson
Copy link
Member Author

Landed as 47c3c58

@mhdawson mhdawson closed this May 16, 2017
mhdawson added a commit that referenced this pull request May 16, 2017
@mhdawson
test: improve N-API test coverage
47c3c58 
Add tests to cover functions that return globals

PR-URL: #13006
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@mhdawson
test: improve N-API test coverage
223c992 
Add tests to cover functions that return globals

PR-URL: nodejs#13006
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@mhdawson mhdawson deleted the napi-cov4 branch June 28, 2017 19:23
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@mhdawson
test: improve N-API test coverage
67e0372 
Add tests to cover functions that return globals

PR-URL: nodejs#13006
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@mhdawson @MylesBorins
test: improve N-API test coverage
314f22d 
Add tests to cover functions that return globals

Backport-PR-URL: #19447
PR-URL: #13006
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongin jasongin jasongin approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhdawson @addaleax @cjihrig @jasongin @nodejs-github-bot