src: remove unnecessary forward declaration #13081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't see that the forward declaration of class Connection is needed and wanted to raise this in case it was overlooked after a previous change.
nodejs-github-bot
added
c++
addaleax
approved these changes
May 17, 2017
cjihrig
approved these changes
May 17, 2017
test/arm-fanned failure does not look relatedReinitialized existing Git repository in /home/iojs/build/workspace/node-test-binary-arm/.git/
+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/master:refs/remotes/reference/master +refs/heads/v4.x-staging:refs/remotes/reference/v4.x-staging +refs/heads/v6.x-staging:refs/remotes/reference/v6.x-staging +refs/heads/v7.x-staging:refs/remotes/reference/v7.x-staging +refs/heads/v8.x-staging:refs/remotes/reference/v8.x-staging
From file:///home/iojs/.ccache/node.shared.reference
5debcce..6342988 master -> reference/master
real 0m2.386s
user 0m0.470s
sys 0m0.390s
+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/jenkins-node-test-commit-arm-fanned-8800-binary-pi1p/cc-armv7:refs/remotes/jenkins_tmp
fatal: Couldn't find remote ref refs/heads/jenkins-node-test-commit-arm-fanned-8800-binary-pi1p/cc-armv7
fatal: The remote end hung up unexpectedly
real 0m0.303s
user 0m0.090s
sys 0m0.030s
+ echo Could not fetch refs/heads/jenkins-node-test-commit-arm-fanned-8800-binary-pi1p/cc-armv7 from the local reference repo, trying GitHub.
Could not fetch refs/heads/jenkins-node-test-commit-arm-fanned-8800-binary-pi1p/cc-armv7 from the local reference repo, trying GitHub.
+ grep -q '^github.com' /home/iojs/.ssh/known_hosts
+ ssh-agent sh -c 'ssh-add **** && git fetch --no-tags git@github.com:janeasystems/node_binary_tmp.git +refs/heads/jenkins-node-test-commit-arm-fanned-8800-binary-pi1p/cc-armv7:refs/remotes/jenkins_tmp'
Identity added: **** (rsa w/o comment)
fatal: Couldn't find remote ref refs/heads/jenkins-node-test-commit-arm-fanned-8800-binary-pi1p/cc-armv7
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Saving reports...
Processing '/var/lib/jenkins/jobs/node-test-binary-arm/configurations/axis-RUN_SUBSET/1/axis-label/pi3-raspbian-jessie/builds/8091/tap-master-files/test.tap'
Parsing TAP test result [/var/lib/jenkins/jobs/node-test-binary-arm/configurations/axis-RUN_SUBSET/1/axis-label/pi3-raspbian-jessie/builds/8091/tap-master-files/test.tap].
TAP Reports Processing: FINISH
Checking ^not ok
Notifying upstream projects of job completion
Finished: FAILURE |
danbev
added a commit
to danbev/node
that referenced
this pull request
May 22, 2017
I can't see that the forward declaration of class Connection is needed and wanted to raise this in case it was overlooked after a previous change. PR-URL: nodejs#13081 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in d54ec72 |
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
I can't see that the forward declaration of class Connection is needed and wanted to raise this in case it was overlooked after a previous change. PR-URL: #13081 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
I can't see that the forward declaration of class Connection is needed and wanted to raise this in case it was overlooked after a previous change. PR-URL: #13081 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't see that the forward declaration of class Connection is needed
and wanted to raise this in case it was overlooked after a previous
change.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src