Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: correct endif comment SRC_NODE_API_H__ #13190

Closed
wants to merge 1 commit into from
Closed

src: correct endif comment SRC_NODE_API_H__ #13190

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 24, 2017

Really minor but I could not find an open PR for anything n-api where
this could be changed, so creating this so that it is not forgotten.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: correct endif comment SRC_NODE_API_H__
9ce0f52 
Really minor but I could not find an open PR for anything n-api where
this could be changed, so creating this so that it is not forgotten.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels May 24, 2017
addaleax
addaleax approved these changes May 24, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d dare say this doesn’t need 48 hours to land ;)

mhdawson
mhdawson approved these changes May 24, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell
jasnell approved these changes May 24, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This shouldn't need to wait the 48 hours to land

danbev added a commit to danbev/node that referenced this pull request May 24, 2017
@danbev
src: correct endif comment SRC_NODE_API_H__
260cd41 
Really minor but I could not find an open PR for anything n-api where
this could be changed, so creating this so that it is not forgotten.

PR-URL: nodejs#13190
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev
Copy link
Contributor Author

danbev commented May 24, 2017

Landed in 260cd41

@danbev danbev closed this May 24, 2017
@danbev danbev deleted the napi-correct-endif-comment branch May 24, 2017 18:04
jasnell pushed a commit that referenced this pull request May 25, 2017
@danbev @jasnell
src: correct endif comment SRC_NODE_API_H__
0c5c0b1 
Really minor but I could not find an open PR for anything n-api where
this could be changed, so creating this so that it is not forgotten.

PR-URL: #13190
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
@danbev @jasnell
src: correct endif comment SRC_NODE_API_H__
3ccef8e 
Really minor but I could not find an open PR for anything n-api where
this could be changed, so creating this so that it is not forgotten.

PR-URL: #13190
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@danbev
src: correct endif comment SRC_NODE_API_H__
278ba33 
Really minor but I could not find an open PR for anything n-api where
this could be changed, so creating this so that it is not forgotten.

PR-URL: nodejs#13190
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@danbev @MylesBorins
src: correct endif comment SRC_NODE_API_H__
a8c7374 
Really minor but I could not find an open PR for anything n-api where
this could be changed, so creating this so that it is not forgotten.

Backport-PR-URL: #19447
PR-URL: #13190
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
@ryan-ally ryan-ally mentioned this pull request Jun 20, 2023
Open
@aliscco aliscco mentioned this pull request Jun 20, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Jun 21, 2023
Open
@137717unity 137717unity mentioned this pull request Jun 21, 2023
Open
@aliscco aliscco mentioned this pull request Jun 21, 2023
Open
@adamlaska adamlaska mentioned this pull request Jun 21, 2023
Open
This was referenced Jun 21, 2023
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
This was referenced Jun 22, 2023
Open
Open
@baby636 baby636 mentioned this pull request Jun 22, 2023
Open
@aliscco aliscco mentioned this pull request Jun 22, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
This was referenced Jun 22, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
This was referenced Jul 6, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danbev @jasnell @addaleax @cjihrig @mhdawson @nodejs-github-bot