-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve n-api coverage for typed arrays #13244
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,10 +95,58 @@ napi_value External(napi_env env, napi_callback_info info) { | |
return output_array; | ||
} | ||
|
||
napi_value CreateTypedArray(napi_env env, napi_callback_info info) { | ||
size_t argc = 2; | ||
napi_value args[2]; | ||
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL)); | ||
|
||
NAPI_ASSERT(env, argc == 2, "Wrong number of arguments"); | ||
|
||
napi_valuetype valuetype0; | ||
NAPI_CALL(env, napi_typeof(env, args[0], &valuetype0)); | ||
|
||
NAPI_ASSERT(env, valuetype0 == napi_object, | ||
"Wrong type of argments. Expects a typed array as first argument."); | ||
|
||
napi_value input_array = args[0]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Can you declare |
||
bool is_typedarray; | ||
NAPI_CALL(env, napi_is_typedarray(env, input_array, &is_typedarray)); | ||
|
||
NAPI_ASSERT(env, is_typedarray, | ||
"Wrong type of argments. Expects a typed array as first argument."); | ||
|
||
napi_valuetype valuetype1; | ||
NAPI_CALL(env, napi_typeof(env, args[1], &valuetype1)); | ||
|
||
NAPI_ASSERT(env, valuetype1 == napi_object, | ||
"Wrong type of argments. Expects an array buffer as second argument."); | ||
|
||
napi_value input_buffer = args[1]; | ||
bool is_arraybuffer; | ||
NAPI_CALL(env, napi_is_arraybuffer(env, input_buffer, &is_arraybuffer)); | ||
|
||
NAPI_ASSERT(env, is_arraybuffer, | ||
"Wrong type of argments. Expects an array buffer as second argument."); | ||
|
||
napi_typedarray_type type; | ||
napi_value in_array_buffer; | ||
size_t byte_offset; | ||
size_t length; | ||
NAPI_CALL(env, napi_get_typedarray_info( | ||
env, input_array, &type, &length, NULL, &in_array_buffer, &byte_offset)); | ||
|
||
napi_value output_array; | ||
NAPI_CALL(env, napi_create_typedarray( | ||
env, type, length, input_buffer, byte_offset, &output_array)); | ||
|
||
return output_array; | ||
} | ||
|
||
void Init(napi_env env, napi_value exports, napi_value module, void* priv) { | ||
napi_property_descriptor descriptors[] = { | ||
DECLARE_NAPI_PROPERTY("Multiply", Multiply), | ||
DECLARE_NAPI_PROPERTY("External", External), | ||
DECLARE_NAPI_PROPERTY("CreateTypedArray", CreateTypedArray), | ||
}; | ||
|
||
NAPI_CALL_RETURN_VOID(env, napi_define_properties( | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert.strictNotEqual()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, thanks.