doc: fix code examples in url.md #13288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
| @@ -515,7 +516,7 @@ const params = new URLSearchParams({ | |||
| query: ['first', 'second'] | |||
| }); | |||
| console.log(params.getAll('query')); | |||
| // Prints ['first,second'] | |||
| // Prints [ 'first,second' ] | |||
There was a problem hiding this comment.
[ 'first', 'second' ] space after the comma
There was a problem hiding this comment.
This is an array with a single element :) It literally prints [ 'first,second' ].
There was a problem hiding this comment.
Ack. I was trying console.log(['first','second'])
addaleax
approved these changes
May 29, 2017
cjihrig
approved these changes
May 29, 2017
jasnell
approved these changes
May 30, 2017
|
Landed in f1b2e68 |
vsemozhetbyt
added a commit
that referenced
this pull request
May 31, 2017
* Update outputs. * Refine spaces. * Restore missing part. PR-URL: #13288 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
* Update outputs. * Refine spaces. * Restore missing part. PR-URL: #13288 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Closed
3 tasks
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
|
Almost all the changes is for new URL format not applied for x6 docs, so do-not-land is valid here (other nits will be fixed when doc linting is backported). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, url
This is a retry of #13268 after #12710 landed (which has made
url.mdtoo different doc to just resolve the conflicts). Sorry for re-bothering.